> -----Original Message----- > From: Christoph Hellwig <[email protected]> > Sent: Monday, 17 June 2019 5:15 PM > To: Alastair D'Silva <[email protected]> > Cc: Peter Zijlstra <[email protected]>; Andrew Morton <akpm@linux- > foundation.org>; David Hildenbrand <[email protected]>; Oscar Salvador > <[email protected]>; Michal Hocko <[email protected]>; Pavel Tatashin > <[email protected]>; Wei Yang <[email protected]>; > Arun KS <[email protected]>; Qian Cai <[email protected]>; Thomas Gleixner > <[email protected]>; Ingo Molnar <[email protected]>; Josh Poimboeuf > <[email protected]>; Jiri Kosina <[email protected]>; Mukesh Ojha > <[email protected]>; Mike Rapoport <[email protected]>; > Baoquan He <[email protected]>; Logan Gunthorpe > <[email protected]>; [email protected]; linux- > [email protected]; [email protected] > Subject: Re: [PATCH 5/5] mm/hotplug: export try_online_node > > On Mon, Jun 17, 2019 at 05:05:30PM +1000, Alastair D'Silva wrote: > > On Mon, 2019-06-17 at 08:59 +0200, Peter Zijlstra wrote: > > > On Mon, Jun 17, 2019 at 02:36:31PM +1000, Alastair D'Silva wrote: > > > > From: Alastair D'Silva <[email protected]> > > > > > > > > If an external driver module supplies physical memory and needs to > > > > expose > > > > > > Why would you ever want to allow a module to do such a thing? > > > > > > > I'm working on a driver for Storage Class Memory, connected via an > > OpenCAPI link. > > > > The memory is only usable once the card says it's OK to access it. > > And all that should go through our pmem APIs, not not directly poke into mm > internals. And if you still need core patches send them along with the actual > driver.
I tried that, but I was getting crashes as the NUMA data structures for that node were not initialised. Calling this was required to prevent uninitialized accesses in the pmem library. -- Alastair D'Silva mob: 0423 762 819 skype: alastair_dsilva msn: [email protected] blog: http://alastair.d-silva.org Twitter: @EvilDeece
