On 2018/6/18 6:09 PM, Florian Schmaus wrote: > Fixes an error condition reported by checkpatch.pl which is caused by > assigning a variable in an if condition. > > Signed-off-by: Florian Schmaus <[email protected]>
Signed-off-by: Coly Li <[email protected]> Added into for-next patch set. Thanks. Coly Li > --- > drivers/md/bcache/super.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c > index db7177d422e5..f09f4f046315 100644 > --- a/drivers/md/bcache/super.c > +++ b/drivers/md/bcache/super.c > @@ -2328,9 +2328,15 @@ static int __init bcache_init(void) > return bcache_major; > } > > - if (!(bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0)) || > - !(bcache_kobj = kobject_create_and_add("bcache", fs_kobj)) || > - bch_request_init() || > + bcache_wq = alloc_workqueue("bcache", WQ_MEM_RECLAIM, 0); > + if (!bcache_wq) > + goto err; > + > + bcache_kobj = kobject_create_and_add("bcache", fs_kobj); > + if (!bcache_kobj) > + goto err; > + > + if (bch_request_init() || > bch_debug_init(bcache_kobj) || closure_debug_init() || > sysfs_create_files(bcache_kobj, files)) > goto err; >
