Hi James, On Thu, Feb 15, 2018 at 03:13:33PM -0800, James A. MacInnes wrote: > 1 << BIT() causes double shift when the macro is unwrapped > removed extra "1 <<"
No Signed-off-by... But this is already fixed: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=7d54d0d38ec42559c891526f079f1e035cd4b3ae -- Sebastian > --- > drivers/power/supply/sbs-manager.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/supply/sbs-manager.c > b/drivers/power/supply/sbs-manager.c > index ccb4217..cb6e8f6 100644 > --- a/drivers/power/supply/sbs-manager.c > +++ b/drivers/power/supply/sbs-manager.c > @@ -183,7 +183,7 @@ static int sbsm_select(struct i2c_mux_core *muxc, u32 > chan) > return ret; > > /* chan goes from 1 ... 4 */ > - reg = 1 << BIT(SBSM_SMB_BAT_OFFSET + chan); > + reg = BIT(SBSM_SMB_BAT_OFFSET + chan); > ret = sbsm_write_word(data->client, SBSM_CMD_BATSYSSTATE, reg); > if (ret) > dev_err(dev, "Failed to select channel %i\n", chan); > -- > 2.7.4 >
signature.asc
Description: PGP signature
