> -----Original Message----- > From: Greg KH [mailto:[email protected]] > Sent: Friday, October 20, 2017 8:24 AM > To: Limonciello, Mario <[email protected]> > Cc: [email protected]; Andy Shevchenko <[email protected]>; > LKML <[email protected]>; [email protected]; Andy > Lutomirski <[email protected]>; [email protected]; [email protected]; > [email protected]; [email protected]; [email protected]; Alan Cox > <[email protected]> > Subject: Re: [PATCH v10 13/15] platform/x86: wmi: create userspace interface > for > drivers > > On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote: > > +#ifdef CONFIG_COMPAT > > + .compat_ioctl = wmi_ioctl, > > Why do you still need a compat ioctl?
Being able to run 32 bit app on 64 bit kernel. Removing the .compat_ioctl definition and they fail. So do you mean specifically the #ifdef CONFIG_COMPAT? I do see that compat_ioctl is declared without it in linux/fs.h, but I'll admit I'm unsure what happens if the kernel is compiled without CONFIG_COMPAT and you try to run 32 bit apps. _Should_ that work?
