On Thu, Oct 19, 2017 at 12:50:16PM -0500, Mario Limonciello wrote: > + wblock = container_of(wdev, struct wmi_block, dev); > + if (!wblock) > + return -ENODEV;
How can container_of() ever return NULL? If so, you have a very odd
memory layout...
> + list_for_each_entry_safe(wblock, next, &wmi_block_list, list) {
> + wdriver = container_of(wblock->dev.dev.driver,
> + struct wmi_driver, driver);
> + if (!wdriver)
> + continue;
Same here. And other places in this file.
thanks,
greg k-h

