On Thu 14 Sep 14:24 PDT 2017, Chris Lew wrote:

> Endianness can vary in the system, add le32_to_cpu when comparing
> size values from smem.
> 
> Signed-off-by: Chris Lew <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn

> ---
> 
> Changes since v1:
> - New change
> 
>  drivers/soc/qcom/smem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
> index c28275be0038..db04c45d4132 100644
> --- a/drivers/soc/qcom/smem.c
> +++ b/drivers/soc/qcom/smem.c
> @@ -698,7 +698,7 @@ static int qcom_smem_enumerate_partitions(struct 
> qcom_smem *smem,
>                       return -EINVAL;
>               }
>  
> -             if (header->size != entry->size) {
> +             if (le32_to_cpu(header->size) != le32_to_cpu(entry->size)) {
>                       dev_err(smem->dev,
>                               "Partition %d has invalid size\n", i);
>                       return -EINVAL;
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

Reply via email to