Hi Guochun, Le 02/08/2017 à 10:36, Boris Brezillon a écrit : > Hi Matthias, > > On Tue, 1 Aug 2017 14:33:22 +0200 > Matthias Brugger <[email protected]> wrote: > >> On 07/25/2017 04:10 AM, Guochun Mao wrote: >>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor" >>> for nor flash node's compatible strings. >>> >>> Reviewed-by: Matthias Brugger <[email protected]> >>> Signed-off-by: Guochun Mao <[email protected]> >>> --- >>> .../devicetree/bindings/mtd/mtk-quadspi.txt | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt >>> b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt >>> index 5ded66a..9845ff4 100644 >>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt >>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt >>> @@ -3,6 +3,8 @@ >>> Required properties: >>> - compatible: The possible values are: >>> "mediatek,mt2701-nor" >>> + "mediatek,mt2712-nor" >>> + "mediatek,mt7622-nor" >>> "mediatek,mt7623-nor" >>> "mediatek,mt8173-nor" >>> For mt8173, compatible should be "mediatek,mt8173-nor". >>>
There should be another patch to update the mtk_nor_of_ids[] array in the mtk-quadspi.c driver, shouldn't it? Currently, I only see the "mediatek,mt8173-nor" compatible string at the driver side. The driver and its documentation should be aligned and both patches should be applied at the same time. Best regards, Cyrille >> >> Boris, will you take this through your tree, or do you prefer that I take it? > > I'm not the spi-nor maintainer, you should ask Cyrille or Marek. > > Regards, > > Boris > > ______________________________________________________ > Linux MTD discussion mailing list > http://lists.infradead.org/mailman/listinfo/linux-mtd/ >
