On 2017년 07월 03일 19:10, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by <linux/sysfs.h> work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 621 176 0 797 31d > drivers/devfreq/governor_userspace.o > > File size After adding 'const': > text data bss dec hex filename > 670 144 0 814 32e > drivers/devfreq/governor_userspace.o > > Signed-off-by: Arvind Yadav <[email protected]> > --- > drivers/devfreq/governor_userspace.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/devfreq/governor_userspace.c > b/drivers/devfreq/governor_userspace.c > index 1769760..77028c2 100644 > --- a/drivers/devfreq/governor_userspace.c > +++ b/drivers/devfreq/governor_userspace.c > @@ -86,7 +86,7 @@ static ssize_t show_freq(struct device *dev, struct > device_attribute *attr, > &dev_attr_set_freq.attr, > NULL, > }; > -static struct attribute_group dev_attr_group = { > +static const struct attribute_group dev_attr_group = { > .name = "userspace", > .attrs = dev_entries, > }; >
Looks good to me. Reviewed-by: Chanwoo Choi <[email protected]> -- Best Regards, Chanwoo Choi Samsung Electronics
