Hi Greg,

On Tue,  6 Jun 2017 21:22:20 +0200 Greg Kroah-Hartman 
<[email protected]> wrote:
>
> -static struct device_attribute serdev_device_attrs[] = {
> -     __ATTR_RO(modalias),
> -     __ATTR_NULL
> +static struct attribute *serdev_device_attrs[] = {
                            ^^^^^^^^^^^^^^^^^^^
Should have been "serdev_device_groups"

> +     &dev_attr_modalias.attr,
> +     NULL,
>  };
> +ATTRIBUTE_GROUPS(serdev_device);
>  
>  static struct bus_type serdev_bus_type = {
>       .name           = "serial",
> @@ -262,7 +264,7 @@ static struct bus_type serdev_bus_type = {
>       .probe          = serdev_drv_probe,
>       .remove         = serdev_drv_remove,
>       .uevent         = serdev_uevent,
> -     .dev_attrs      = serdev_device_attrs,
> +     .dev_groups     = serdev_device_groups,
>  };
-- 
Cheers,
Stephen Rothwell

Reply via email to