I see that I forgot cc'ing Dave Airlie on this, and I just realised that the backlight problem isn't just a warning, but it actually causes a build failure if backlight is built as a module. I missed this in my hurry to get this out the door, sorry.
Den 23.02.2017 14.29, skrev Noralf Trønnes:
Dave pulled tinydrm yesterday which triggered some compiler warnings: Dave Airlie: drivers/gpu/drm/tinydrm/mipi-dbi.c: In function ‘mipi_dbi_debugfs_command_write’: drivers/gpu/drm/tinydrm/mipi-dbi.c:905:8: warning: ‘cmd’ may be used uninitialized in this function [-Wmaybe-uninitialized] ret = mipi_dbi_command_buf(mipi, cmd, parameters, i); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ I didn't see this on gcc 4.8, but it showed up when I used gcc 6.2. kbuild test robot: [drm:drm-next 1199/1208] drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c:198:26: error: redefinition of 'tinydrm_of_find_backlight' kbuild test robot: drivers/gpu/drm/tinydrm/mipi-dbi.c: In function 'mipi_dbi_typec1_command':drivers/gpu/drm/tinydrm/mipi-dbi.c:65:20: warning: field width specifier '*' expects argument of type 'int', but argument 5 has type 'size_t {aka long unsigned int}' [-Wformat=]DRM_DEBUG_DRIVER("cmd=%02x, par=%*ph\n", cmd, len, data); \ ^ include/drm/drmP.h:228:40: note: in definition of macro 'DRM_DEBUG_DRIVER' drm_printk(KERN_DEBUG, DRM_UT_DRIVER, fmt, ##__VA_ARGS__) ^~~drivers/gpu/drm/tinydrm/mipi-dbi.c:671:2: note: in expansion of macro 'MIPI_DBI_DEBUG_COMMAND'MIPI_DBI_DEBUG_COMMAND(cmd, parameters, num); ^~~~~~~~~~~~~~~~~~~~~~ Noralf. Noralf Trønnes (3): drm/tinydrm: mipi-dbi: Silence: ‘cmd’ may be used uninitialized drm/tinydrm: mipi-dbi: Fix field width specifier warning drm/tinydrm: helpers: Properly fix backlight dependency drivers/gpu/drm/tinydrm/mipi-dbi.c | 6 +++--- include/drm/tinydrm/tinydrm-helpers.h | 19 ------------------- 2 files changed, 3 insertions(+), 22 deletions(-) -- 2.10.2
