On 11/10/16 11:53, Juergen Gross wrote: > On 10/10/16 12:13, Paul Durrant wrote: >> The Xen docs specify several flags which a guest can set to advertize >> which values of the xenstore control/shutdown key it will recognize. >> This patch adds code to write all the relevant feature-flag keys. >> >> Signed-off-by: Paul Durrant <[email protected]> >> Cc: Boris Ostrovsky <[email protected]> >> Cc: David Vrabel <[email protected]> >> Cc: Juergen Gross <[email protected]> > > Hmm, I'd prefer node[] allocated on the stack over dynamic allocation. > > What about something like the following? It will at least issue build > warnings in case the size is too small, will use less memory and less > coding.
You still want snprintf() just to be sure. You can add a Reviewed-by David Vrabel <[email protected]> if you make this change. David
