From: <[email protected]>
Date: Fri, 3 Jun 2016 02:07:15 -0700
> From: Tien Hock Loh <[email protected]>
>
> This adds support for TSE PCS that uses SGMII adapter when the phy-mode of
> the dwmac is set to sgmii
>
> Signed-off-by: Tien Hock Loh <[email protected]>
Please at least make an effort to use consistent coding style.
You rework this function to do this:
> - if (!splitter_base)
> - return;
> + if (splitter_base) {
And then you add something like this:
> + if ((tse_pcs_base) && (sgmii_adapter_base)) {
> + tse_pcs_fix_mac_speed(&dwmac->pcs, phy_dev, speed);
> + }
Excessive parenthesis in the if() condition, and single statement
basic blocks do not get curly braces.