Hi Wolfram, > -----Original Message----- > From: Sricharan [mailto:[email protected]] > Sent: Saturday, February 13, 2016 12:29 PM > To: 'Wolfram Sang' > Cc: '[email protected]'; '[email protected]'; > '[email protected]'; '[email protected]'; 'linux- > [email protected]'; '[email protected]'; '[email protected]'; > '[email protected]'; '[email protected]'; > '[email protected]'; '[email protected]'; '[email protected]' > Subject: RE: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities > > Hi Wolfram, > > > -----Original Message----- > > From: Wolfram Sang [mailto:[email protected]] > > Sent: Saturday, February 13, 2016 12:08 AM > > To: Sricharan R > > Cc: [email protected]; [email protected]; > > [email protected]; [email protected]; linux- > > [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; > > [email protected]; [email protected]; [email protected] > > Subject: Re: [PATCH V7 4/6] i2c: qup: Add bam dma capabilities > > > > On Tue, Jan 19, 2016 at 03:32:44PM +0530, Sricharan R wrote: > > > QUP cores can be attached to a BAM module, which acts as a dma > > > engine for the QUP core. When DMA with BAM is enabled, the BAM > > > consumer > > pipe > > > transmitted data is written to the output FIFO and the BAM producer > > > pipe received data is read from the input FIFO. > > > > > > With BAM capabilities, qup-i2c core can transfer more than > > > 256 bytes, without a 'stop' which is not possible otherwise. > > > > > > Signed-off-by: Sricharan R <[email protected]> > > > Reviewed-by: Andy Gross <[email protected]> > > > Tested-by: Archit Taneja <[email protected]> > > > Tested-by: Telkar Nagender <[email protected]> > > > > My code checkers found some issues: > > > > SPARSE > > drivers/i2c/busses/i2c-qup.c:555:6: warning: symbol 'qup_sg_set_buf' > > was not declared. Should it be static? > > drivers/i2c/busses/i2c-qup.c:1243:50: warning: dubious: !x & !y > > SMATCH > > drivers/i2c/busses/i2c-qup.c:165 qup_sg_set_buf warn: unused return: s > > = > > sg_next() > > drivers/i2c/busses/i2c-qup.c:165 qup_sg_set_buf warn: unused return: s > > = > > sg_next() > > drivers/i2c/busses/i2c-qup.c:1243 qup_i2c_xfer_v2() warn: add some > > parenthesis here? > > CPPCHECK > > drivers/i2c/busses/i2c-qup.c:1243: style: Boolean result is used in > > bitwise operation. Clarify expression with parentheses. > > SPATCH > > drivers/i2c/busses/i2c-qup.c:1380:2-13: WARNING: Assignment of bool to > > 0/1 > > drivers/i2c/busses/i2c-qup.c:1481:1-13: WARNING: Assignment of bool to > 0/1 > > CC drivers/i2c/busses/i2c-qup.o > > drivers/i2c/busses/i2c-qup.c:555:6: warning: no previous prototype for > > 'qup_sg_set_buf' [-Wmissing-prototypes] void qup_sg_set_buf(struct > > scatterlist *sg, void *buf, struct qup_i2c_tag *tg, > > > > Can you fix them and resend?? > Really sorry for the delay , sent it here [1]
Also, while testing this series in one of a new platform, found that an additional Regression and a fix is required on top of this series. So can I send a separate fix on top of this series ? [1] https://patchwork.ozlabs.org/patch/586125/ Regards, Sricharan
