On 08/12/2015 22:45, Richard Weinberger wrote: > Am 08.12.2015 um 21:37 schrieb Tristan Schmelcher: >> On 6 December 2015 at 09:43, Mickaël Salaün <[email protected]> wrote: >>> Well, I'm concerned to use umask because it is not thread-safe and drivers >>> may use create_mem_file() in a multi-theaded context. >> >> You are right. We should perhaps set the umask to 0700 permanently >> during process start. But I am not sure if this will interfere with >> other UML code. > > It *should* not hurt. Let's see what explodes. :)
We can't force the kernel process umask without breaking compatibility with current implementation, especially with hostfs (i.e. the host umask prevail the guest one). >>> I prefer to stick to fchmod and handle the race-condition with O_TMPFILE >>> unsell someone is sure that this will not create bugs :) >> >> The fchmod call is basically useless and should probably be removed. > > I agree. I propose then to simply remove the fchmod call and let the O_TMPFILE flag do the magic :) Regards, Mickaël
signature.asc
Description: OpenPGP digital signature
