On 10/17/26 3:29 PM, Erikas Bitovtas wrote:
> On 10/16/26 13:56, Konrad Dybcio wrote:
>> On 10/13/26 3:58 PM, Erikas Bitovtas wrote:
>>> Samsung Galaxy A52/A72 are devices released on atoll (SM7125) platform
>>> in 2021. Add initial device tree for SM7125 Samsung platform with
>>> +&soc {
>>> + i2c_17: i2c-17 {
>>
>> This is not a MMIO device, so it doesn't belong under /soc
>>
> Will move it to / in v5.
>> Have you tried using the bus through the normal QUP driver path?
>>
> No, I haven't. GPI DMA support for this platform is not yet upstream.
It's a copy-paste job, try it out please.
>>> + compatible = "i2c-gpio";
>>> + sda-gpios = <&tlmm 51 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
>>> + scl-gpios = <&tlmm 52 (GPIO_ACTIVE_HIGH|GPIO_OPEN_DRAIN)>;
>>
>> style nit: (foo | bar) instead of (foor|bar), please
>>
> Will fix that in v5.
>>> +&usb_1 {
>>> + qcom,select-utmi-as-pipe-clk;
>>
>> Is there no superspeed / DP altmode?
>>
> I could not find anything that confirms super-speed or DP altmode on
> these devices. Besides, ufshcd-qcom fails with "link startup failed 1"
> after setting super-speed and removing "qcom,select-utmi-as-pipe-clk".
On the stock firmware, if you plug in a display via the type-c port
(perhaps via a dock), does it show video output?
Konrad
