Re: [PATCH 4/6] mailbox: Add AMD PL Mailbox soft IP controller

[Ben Levinsky]

On 10/16/26 7:56 AM, Krzysztof Kozlowski wrote:
> On 16/10/2026 16:54, Shah, Tanmay wrote:
>>>> +static const struct of_device_id amd_pl_mbox_of_match[] = {
>>>> +  { .compatible = "amd,zynqmp-pl-mbox-2.1" },
>>>> +  { .compatible = "amd,versal-pl-mbox-2.1" },
>>>> +  { .compatible = "amd,versal-net-pl-mbox-2.1" },
>>>> +  { .compatible = "amd,versal2-pl-mbox-2.1" },
>>>
>>> So all of them are compatible? Then why do you need all this?
>>>
>>
>> Hi Krzysztof,
>>
>> This block will be used on 4 SoC - zynqmp, versal, versal-net & versal2.
>> IIRC we should list each SoC where the device/hw block is available.
> 
> No, you do not list here every compatible device. You only list
> fallbacks. Please open other drivers to see how this is done. Only hwmon
> is an exception here with its own reason.
> 
> 
> Best regards,
> Krzysztof

Hi Krzysztof,

Thanks, understood. In v2 the binding keeps the SoC-specific compatibles
with amd,zynqmp-pl-mbox-2.1 as the fallback, and the driver matches only
the fallback. I also withdraw the xlnx,mailbox-2.1 proposal from my
earlier reply.

Thanks,
Ben