On 10/14/26 10:42, Nick Desaulniers wrote:
On Tue, Oct 13, 2026 at 3:01 PM Mark Brown <[email protected]> wrote:
On Tue, Oct 13, 2026 at 02:07:28PM -0700, Nick Desaulniers wrote:
On Tue, Oct 13, 2026 at 12:40 PM Mark Brown <[email protected]> wrote:
+ clang_target[riscv]=riscv64-linux-gnu
+ clang_target[s390]=s390x-linux-gnu
+ clang_target[x86]=x86_64-linux-gnu
^ should this be either i386-linux-gnu or i686-linux-gnu, or does
`-m32` get set somewhere?
Hrm, that'll just be a cut'n'paste from lib.mk which does not so far as
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/lib.mk
I can see set -m32 - it sets i386-linux-gnu for _i386. Does that need a
fix too, or am I missing something with how it works?
Ah, no looking at
commit 624c60f326c6 ("selftests: fix LLVM build for i386 and x86_64")
it looks like selftests have i386, x86, and x86_64 where x86 is x86_64
IIUC. I see you also have a distinct i386 target. My bad.
Acked-by: Nick Desaulniers <[email protected]>
Thank you. Applied kselftest next for 7.4-rc1
thanks,
-- Shuah
