On Thu, 2024-05-23 at 16:54 +0300, Jarkko Sakkinen wrote:
> On Thu May 23, 2024 at 4:38 PM EEST, James Bottomley wrote:
> > On Thu, 2024-05-23 at 16:19 +0300, Jarkko Sakkinen wrote:
> > > There's no reason to encode OID_TPMSealedData at run-time, as it
> > > never changes.
> > >
> > > Replace it with the encoded version, which has exactly the same
> > > size:
> > >
> > > 67 81 05 0A 01 05
> > >
> > > Include OBJECT IDENTIFIER (0x06) tag and length as the epilogue
> > > so
> > > that the OID can be simply copied to the blob.
> >
> > This is true, but if we're going to do this, we should expand the
> > OID
> > registry functions (in lib/oid_registry.c) to do something like
> > encode_OID. The registry already contains the hex above minus the
> > two
> > prefixes (which are easy to add).
>
> Yes, I do agree with this idea, and I named variable the I named
> it to make it obvious that generation is possible.
>
> It would be best to have a single source, which could be just
> a CSV file with entries like:
>
> <Name>,<OID number>
>
> And then in scripts/ there should be a script that takes this
> source and generates oid_registry.gen.{h,c}. The existing
> oid_registry.h should really just include oid_registry.gen.h
> then to make this transparent change.
>
> And then in the series where OID's are encoded per-subsystem
> patch that takes pre-encoded OID into use.
>
> Happy to review such patch set if it is pushed forward.
Heh, OK, since I'm the one who thinks it's quite easy, I'll give it a
go.
James
