Re: [PATCH 1/2] crypto: inside-secure - Added support for the CHACHA20 skcipher

[Antoine Tenart]

Hi Pascal,

On Tue, Sep 10, 2019 at 04:38:12PM +0200, Pascal van Leeuwen wrote:
>  
> @@ -112,7 +123,7 @@ static void safexcel_cipher_token(struct 
> safexcel_cipher_ctx *ctx, u8 *iv,
>                       block_sz = DES3_EDE_BLOCK_SIZE;
>                       cdesc->control_data.options |= 
> EIP197_OPTION_2_TOKEN_IV_CMD;
>                       break;
> -             case SAFEXCEL_AES:
> +             default: /* case SAFEXCEL_AES */

Can't you keep an explicit case here?

>                       block_sz = AES_BLOCK_SIZE;
>                       cdesc->control_data.options |= 
> EIP197_OPTION_4_TOKEN_IV_CMD;
>                       break;

Thanks,
Antoine

-- 
Antoine Ténart, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com