> -----Original Message----- > From: linux-crypto-ow...@vger.kernel.org <linux-crypto-ow...@vger.kernel.org> > On Behalf > Of Pascal Van Leeuwen > Sent: Monday, September 9, 2019 12:38 PM > To: Herbert Xu <herb...@gondor.apana.org.au>; Pascal van Leeuwen > <pascalv...@gmail.com> > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > da...@davemloft.net > Subject: RE: [PATCH 0/3] crypto: inside-secure - Add support for the CBCMAC > > > -----Original Message----- > > From: linux-crypto-ow...@vger.kernel.org > > <linux-crypto-ow...@vger.kernel.org> On > Behalf > > Of Herbert Xu > > Sent: Monday, September 9, 2019 9:38 AM > > To: Pascal van Leeuwen <pascalv...@gmail.com> > > Cc: linux-crypto@vger.kernel.org; antoine.ten...@bootlin.com; > > da...@davemloft.net; > > Pascal Van Leeuwen <pvanleeu...@verimatrix.com> > > Subject: Re: [PATCH 0/3] crypto: inside-secure - Add support for the CBCMAC > > > > On Wed, Sep 04, 2019 at 09:36:45AM +0200, Pascal van Leeuwen wrote: > > > This patchset adds support for the (AES) CBCMAC family of authentication > > > algorithms: AES-CBCMAC, AES-XCBCMAC and AES-MAC > > > It has been verified with a Xilinx PCIE FPGA board as well as the Marvell > > > Armada A8K based Macchiatobin development board. > > > > > > Pascal van Leeuwen (3): > > > crypto: inside-secure - Added support for the AES CBCMAC ahash > > > crypto: inside-secure - Added support for the AES XCBC ahash > > > crypto: inside-secure - Added support for the AES-CMAC ahash > > > > > > drivers/crypto/inside-secure/safexcel.c | 3 + > > > drivers/crypto/inside-secure/safexcel.h | 3 + > > > drivers/crypto/inside-secure/safexcel_hash.c | 462 > > > ++++++++++++++++++++++++--- > > > 3 files changed, 427 insertions(+), 41 deletions(-) > > > > This does not apply against cryptodev. > > > Grml, looks like I forgot to include the previous commit. > My bad, will send a fixed v2 shortly ... > Actually, I'm wondering what would be the best approach here: 1) include the CRC32 support into a v2 of this patchset 2) provide the CRC32 support as a seperate, standalone patch to be applied prior to this patchset
Since CRC32 has very little to do with the CBCMAC family, I would think option 2) makes the most sense. So my suggestion would be to supply the CRC32 patch and then resubmit this patchset unmodified. Would that be OK? > > Cheers, > > -- > > Email: Herbert Xu <herb...@gondor.apana.org.au> > > Home Page: http://gondor.apana.org.au/~herbert/ > > PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt > > > Regards, > Pascal van Leeuwen > Silicon IP Architect, Multi-Protocol Engines @ Verimatrix > www.insidesecure.com Regards, Pascal van Leeuwen Silicon IP Architect, Multi-Protocol Engines @ Verimatrix www.insidesecure.com
