Serge Hallyn <serge.hal...@canonical.com> wrote:
> > +int tpm_send(u32 chip_num, void *cmd, size_t buflen)
>
> Hate to nit-pick, but any particular reason you're not following the
> rest of the file and using 'struct tpm_cmd_t *cmd' here?
Ummm... Something else I've just noticed...
static ssize_t tpm_transmit(struct tpm_chip *chip, const char *buf,
size_t bufsiz)
would suggest that buf is read-only, but tpm_transit() keeps casting it away,
and especially, casts it away before passing it to chip->vendor.recv()...
This would seem to indicate a logic error somewhere.
Certainly, tpm_atml_recv() modifies the buffer it is given to...
I suspect the argument and reply buffer pointers should be passed separately.
David
--
To unsubscribe from this list: send the line "unsubscribe linux-crypto" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
