On Wed, 25 Feb 2009, Frank Seidel wrote: > Geert Uytterhoeven wrote: > > Probably people should be reminded tcrypt can only be a module, not > > built-in, > > so it won't waste precious unswappable kernel memory if it's static. > > Thats right, but it also doesn't hurt to simply use kmalloc, does it? :-)
Wel... Using kmalloc() increases code size, makes the code more complex, and increases the risk of introducing a memory leak now or later. > I just stumbled over tcrypt on the make checkstack output and as also > the kerneljanitors todo advises to reduce this footprint where possible > i just wanted to help out here. Reducing stack usage is fine. However, for a loadable test module without concurrency issues it's far easier to do that by just making the data static. With kind regards, Geert Uytterhoeven Software Architect Sony Techsoft Centre Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: geert.uytterhoe...@sonycom.com Internet: http://www.sony-europe.com/ A division of Sony Europe (Belgium) N.V. VAT BE 0413.825.160 · RPR Brussels Fortis · BIC GEBABEBB · IBAN BE41293037680010 -- To unsubscribe from this list: send the line "unsubscribe linux-crypto" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
