On Sun, 2012-07-08 at 22:28 -0600, Gwenole Beauchesne wrote:
> Hi,
>
> 2012/7/9 ykzhao <[email protected]>:
> > On Fri, 2012-07-06 at 10:42 -0600, Gwenole Beauchesne wrote:
> >> Signed-off-by: Gwenole Beauchesne <[email protected]>
> >> ---
> >> va/android/va_android.cpp | 10 +++++-----
> >> va/va_backend.h | 2 +-
> >> va/x11/dri1_util.c | 4 ++--
> >> va/x11/dri2_util.c | 4 ++--
> >> va/x11/va_dricommon.c | 10 +++++-----
> >> va/x11/va_x11.c | 6 +++---
> >> 6 files changed, 18 insertions(+), 18 deletions(-)
> >>
> >
> > There is no problem when the variable of dri_state is renamed to
> > drm_state.
> > But it seems a little confusing as the patch 2 already defines the
> > structure type of drm_state.
>
> Both patches could be merged altogether, if this is what you suggest.
No. What I mean is that the name seems a little confusing. And the
readability of ctx->drm_state is decreased as the patch 2 defines the
data structure of drm_state.
Thanks.
Yakui
_______________________________________________
Libva mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/libva
