On Fri, Feb 10, 2012 at 2:12 AM, Tommi Rantala <[email protected]> wrote:
> - Please base your work against what is available in libunwind.git. That way > you will also avoid changes to generated files (Makefile.in etc) in your > patches. I did some of the mechanical work to get this to compile on x86_64. My tree is at: git clone -b coredump git://github.com/adsharma/libunwind.git https://github.com/adsharma/libunwind/commits/coredump wc -l _UCD*.c | sort -rn 603 _UCD_find_proc_info.c This looks largely unmodified. Perhaps figure out a way to share code with ptrace? Something like src/dwarf/Lparser.c? 332 _UCD_create.c The endianness detection code seems a bit excessive. Code probably needs another round of review. 96 _UCD_access_mem.c 90 _UCD_lib.c 86 _UCD_access_reg.c 51 _UCD_destroy.c 36 _UCD_accessors.c These generally look ok. Other suggestions: * man pages for doc * address compiler warnings * test for memory leaks after unwinding in a loop > > - This one is probably obvious, but let me say it anyway: please change the > indentation to match the style used in libunwind code base. > Yes please. Probably best to start with the git tree above and a make a style-change only commit on top of it and then address the remaining stuff. Thanks for sharing the patch. -Arun _______________________________________________ Libunwind-devel mailing list [email protected] https://lists.nongnu.org/mailman/listinfo/libunwind-devel
