On 02/09/2012 02:03 PM, ext Denys Vlasenko wrote:
Please review.
Hi, couple of comments:
I tested this quickly also on ARM (Nokia N9), and with the register
remapping thing removed from _UCD_access_reg(), the example program
gives backtraces that match what gdb reports for couple of coredumps.
- It would be nice if there was a way to add "backing files" to explicit
address ranges (e.g. based on a copy of /proc/pid/maps taken when the
process crashed). This would allow for processing of coredumps that have
some of the program headers intentionally stripped to save space:
http://gitorious.org/qa-tools/rich-core/trees/master/core-reducer
- Please do not call exit() or _exit() from the library, but fail
gracefully and return some error code. I would remove the _UCD_lib.[ch]
files completely.
- Please base your work against what is available in libunwind.git. That
way you will also avoid changes to generated files (Makefile.in etc) in
your patches.
- This one is probably obvious, but let me say it anyway: please change
the indentation to match the style used in libunwind code base.
--
Tommi Rantala
_______________________________________________
Libunwind-devel mailing list
[email protected]
https://lists.nongnu.org/mailman/listinfo/libunwind-devel
