https://bugs.documentfoundation.org/show_bug.cgi?id=145614
--- Comment #2 from Hossein <[email protected]> --- (In reply to Stephan Bergmann from comment #1) > (In reply to Hossein from comment #0) > > /* Mapping modes */ > > enum MappingMode > > { > > MM_TEXT = 0x01, > > MM_LOMETRIC = 0x02, > > MM_HIMETRIC = 0x03, > > MM_LOENGLISH = 0x04, > > MM_HIENGLISH = 0x05, > > MM_TWIPS = 0x06, > > MM_ISOTROPIC = 0x07, > > MM_ANISOTROPIC = 0x08 > > }; > > Why change the values from decimal to hexadecimal? That's the way they are defined in [MS-WMF] documentation: https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-wmf/97b31821-a0db-4113-a210-fffbcedcec4a In some enumerations in the same file, I had to add some values that were missing. So, when the source of the enum definition is known, I think using the same definitions can help avoid mistakes. If possible, using the same name would also be good. > > constexpr sal_Int32 LF_FACESIZE = 32; > > I guess some explanation is needed what type to use (`sal_Int32` will not be > the best choice in general; even `auto` may be an appropriate choice). Correct. I will add some explanation for this. -- You are receiving this mail because: You are the assignee for the bug.
