https://bugs.documentfoundation.org/show_bug.cgi?id=145614

Stephan Bergmann <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #1 from Stephan Bergmann <[email protected]> ---
(In reply to Hossein from comment #0)
> /* Mapping modes */
> enum MappingMode
> {
>     MM_TEXT        = 0x01,
>     MM_LOMETRIC    = 0x02,
>     MM_HIMETRIC    = 0x03,
>     MM_LOENGLISH   = 0x04,
>     MM_HIENGLISH   = 0x05,
>     MM_TWIPS       = 0x06,
>     MM_ISOTROPIC   = 0x07,
>     MM_ANISOTROPIC = 0x08
> };

Why change the values from decimal to hexadecimal?

> constexpr sal_Int32 LF_FACESIZE = 32;

I guess some explanation is needed what type to use (`sal_Int32` will not be
the best choice in general; even `auto` may be an appropriate choice).

-- 
You are receiving this mail because:
You are the assignee for the bug.

Reply via email to