On 11/03/14 17:38, Diego Biurrun wrote:
> On Tue, Mar 11, 2014 at 03:25:26PM +0100, Luca Barbato wrote:
>> --- a/doc/protocols.texi
>> +++ b/doc/protocols.texi
>> @@ -89,6 +89,26 @@ m3u8 files.
>> +
>> +@item icy_metadata_headers
>> +If the server supports ICY metadata, this contains the ICY specific HTTP
>> reply
>
> ICY-specific
>
>> +headers, separated with newline characters.
>
> separated by
Ok
>
>> +@item icy_metadata_packet
>> +If the server supports ICY metadata, and @option{icy} was set to 1, this
>> +contains the last non-empty metadata packet sent by the server. It should be
>> +polled in regular intervals by applications interested in metadata updates
>> +mid-stream.
>
> mid-stream metadata updates
Ok
>> --- a/libavformat/http.c
>> +++ b/libavformat/http.c
>> @@ -68,6 +68,13 @@ typedef struct {
>> int post_datalen;
>> + int icy;
>> + /* how much data was read since last ICY metadata packet */
>
> the last
Sure
>
>> + /* after how many bytes of read data a new metadata packet will be
>> found */
>> + int icy_metaint;
>
> meta_interval?
>
> This is quite confusing.
>
> /* number of data bytes after which a new metadata packet will be found */
> int icy_meta_interval;
>
> would be better IMO. Or make it icy_meta_ival if need be.
sadly that's the tag, I'd rather keep it as is.
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
