On Tue, 11 Mar 2014, Luca Barbato wrote:

On 11/03/14 16:14, Alessandro Ghedini wrote:
On mar, mar 11, 2014 at 03:25:26 +0100, Luca Barbato wrote:
+// Concat all Icy- header lines
+static int parse_icy(HTTPContext *s, const char *tag, const char *p)
+{
+    int len = 1 + strlen(p) + strlen(tag);
+    int ret;
+
+    if (s->icy_metadata_headers)
+        len += strlen(s->icy_metadata_headers);
+
+    if ((ret = av_reallocp(&s->icy_metadata_headers, len)) < 0)
+        return ret;
+
+    av_strlcatf(s->icy_metadata_headers, len, "%s: %s", tag, p);

ffmpeg also adds a '\n' at the end of the header. This difference breaks mpv's
tags output (instead of having a tag per line, they get printed all on the same
line with some garbage in between). Is this on purpose?

No, thanks for pointing it out. Amended locally.

The patch is ok with me with this amended.

// Martin
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel

Reply via email to