On Sat, Jan 11, 2014 at 06:03:23PM +0100, Janne Grunau wrote: > --- /dev/null > +++ b/libavcodec/aarch64/Makefile > @@ -0,0 +1,10 @@ > +OBJS-$(CONFIG_H264CHROMA) += aarch64/h264chroma_init_aarch64.o > + > +OBJS-$(CONFIG_RV40_DECODER) += aarch64/rv40dsp_init_aarch64.o > + > +OBJS-$(CONFIG_VC1_DECODER) += aarch64/vc1dsp_init_aarch64.o > + > +
Drop the empty lines and make the double empty line a single one. > +NEON-ASM-OBJS-$(CONFIG_H264CHROMA) += aarch64/h264cmc_neon.o > + > +NEON-OBJS-$(HAVE_NEON_EXTERNAL) += $(NEON-ASM-OBJS) > $(NEON-ASM-OBJS-yes) This indirection seems unnecessary; what are you trying to do here? > --- /dev/null > +++ b/libavcodec/aarch64/h264chroma_init_aarch64.c > @@ -0,0 +1,51 @@ > + > +#include <stdint.h> > + > +#include "libavutil/attributes.h" > +#include "libavutil/cpu.h" > +#include "libavutil/aarch64/cpu.h" > +#include "libavcodec/h264chroma.h" > + > +void ff_put_h264_chroma_mc8_neon(uint8_t *, uint8_t *, int, int, int, int); > +void ff_put_h264_chroma_mc4_neon(uint8_t *, uint8_t *, int, int, int, int); > +void ff_put_h264_chroma_mc2_neon(uint8_t *, uint8_t *, int, int, int, int); > + > +void ff_avg_h264_chroma_mc8_neon(uint8_t *, uint8_t *, int, int, int, int); > +void ff_avg_h264_chroma_mc4_neon(uint8_t *, uint8_t *, int, int, int, int); > +void ff_avg_h264_chroma_mc2_neon(uint8_t *, uint8_t *, int, int, int, int); I know the other files are the same, but maybe now would be a good moment not to add any more function declarations w/o variable names anymore. Diego _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
