On Sat, Jan 11, 2014 at 06:03:21PM +0100, Janne Grunau wrote:
> NEON and VFPv4 are not optional for ARMv8. For cpuflag support we are
> handling both as extensions. This is consistant with x86_64 which
> implies SSE2 which is still handled as extension.
consist_e_nt
This is consistent with handling x86_64 which always has SSE2, but still
handles it as an extension.
> --- a/configure
> +++ b/configure
> @@ -1233,6 +1233,15 @@ ARCH_LIST='
>
> +# both NEON and VFPv4 are not really extensions for aarch64 since they are
Start sentences capitalized.
> +# not optional. They are handled as extensions to support disabling
> +# optimizations via cpu flags. This is consistent with x86_64
CPU, end in a period.
> --- a/libavutil/cpu_internal.h
> +++ b/libavutil/aarch64/cpu.c
> @@ -16,18 +16,12 @@
> +int ff_get_cpu_flags_aarch64(void)
> +{
> + return AV_CPU_FLAG_NEON * HAVE_NEON |
> + AV_CPU_FLAG_VFPV4 * HAVE_VFPV4;
nit: spacing looks slightly odd.
> --- a/libavutil/cpu_internal.h
> +++ b/libavutil/aarch64/cpu.h
> @@ -16,18 +16,20 @@
>
> +#define have_neon(flags) CPUEXT(flags, NEON)
> +#define have_vfpv4(flags) CPUEXT(flags, VFPV3)
>
> +#define have_neon_external(flags) CPUEXT_SUFFIX(flags, _EXTERNAL, NEON)
> +#define have_vfpv4_external(flags) CPUEXT_SUFFIX(flags, _EXTERNAL, VFPV3)
>
> +#define have_neon_inline(flags) CPUEXT_SUFFIX(flags, _INLINE, NEON)
> +#define have_vfpv4_inline(flags) CPUEXT_SUFFIX(flags, _INLINE, VFPV3)
s/3/4/ I believe ...
Diego
_______________________________________________
libav-devel mailing list
[email protected]
https://lists.libav.org/mailman/listinfo/libav-devel
