On Fri, Apr 22, 2011 at 3:03 AM, Diego Biurrun <[email protected]> wrote: > On Thu, Apr 21, 2011 at 11:35:43AM -0700, Aℓex Converse wrote: >> On Thu, Apr 21, 2011 at 10:39 AM, Diego Biurrun <[email protected]> wrote: >> > >> > --- a/libavcodec/cook.c >> > +++ b/libavcodec/cook.c >> > @@ -1136,7 +1136,7 @@ static av_cold int cook_decode_init(AVCodecContext >> > *avctx) >> > switch (q->subpacket[s].cookversion) { >> > case MONO: >> > if (q->nb_channels != 1) { >> > - av_log(avctx,AV_LOG_ERROR,"Container channels != 1, >> > report sample!\n"); >> > + av_log_ask_for_sample(avctx, "Container channels != >> > 1.!\n"); >> >> [...] >> >> > - av_log(avctx,AV_LOG_ERROR,"Container channels != 2, >> > report sample!\n"); >> > + av_log_ask_for_sample(avctx, "Container channels != >> > 2.\n"); >> >> This is inconsistent. > > I guess this is a comment for Benjamin, but not related to my patch :) >
It is related to your patch. The first hunk has an exclamation point. The second one does not. Before this patch usage of the exclamation point was consistent. --Alex _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
