Hi, diego asked for more detail.
On Thu, Apr 21, 2011 at 1:02 PM, Diego Biurrun <[email protected]> wrote: > diff --git a/libavcodec/atrac3.c b/libavcodec/atrac3.c [..] > - if (off) > - av_log(NULL,AV_LOG_DEBUG,"Offset of %d not handled, post sample on > ffmpeg-dev.\n",off); > + if (off) { > + av_log(NULL, AV_LOG_DEBUG, "Offset of %d not handled.\n", off); > + av_log_ask_for_sample(NULL, NULL); > + } Not OK. Please create a varage av_log_ask_for_sample(). > diff --git a/libavcodec/cook.c b/libavcodec/cook.c [..] > - av_log(avctx,AV_LOG_ERROR,"Container channels != 1, > report sample!\n"); > + av_log_ask_for_sample(avctx, "Container channels != > 1.!\n"); [..] > - av_log(avctx,AV_LOG_ERROR,"Container channels != 2, > report sample!\n"); > + av_log_ask_for_sample(avctx, "Container channels != > 2.\n"); [..] > - av_log(avctx,AV_LOG_ERROR,"Unknown Cook version, report > sample!\n"); > + av_log_ask_for_sample(avctx, "Unknown Cook version.\n"); [..] > - av_log(avctx,AV_LOG_ERROR,"total_subbands > 53, report > sample!\n"); > + av_log_ask_for_sample(avctx, "total_subbands > 53\n"); [..] > - av_log(avctx,AV_LOG_ERROR,"subbands > 50, report sample!\n"); > + av_log_ask_for_sample(avctx, "subbands > 50\n"); [..] > - av_log(avctx,AV_LOG_ERROR,"Too many subpackets > 5, report > file!\n"); > + av_log_ask_for_sample(avctx, "Too many subpackets > 5\n"); these are OK. > - av_log(avctx,AV_LOG_ERROR,"unknown amount of samples_per_channel = > %d, report sample!\n",q->samples_per_channel); > + av_log(avctx, AV_LOG_ERROR, > + "unknown amount of samples_per_channel = %d\n", > + q->samples_per_channel); > + av_log_ask_for_sample(avctx, NULL); This is not. (Same further down in the patch.) Ronald _______________________________________________ libav-devel mailing list [email protected] https://lists.libav.org/mailman/listinfo/libav-devel
