Hi Bruce,
> On Tue Nov 15 2011 at 15:12:33 MST
> ... we've made some improvements and fixed some bugs in the bootscripts. ...
Thank you for the excellent "lfs-bootscripts-20111114" release.
At the risk of sounding picayunish (just striving for an even higher
perfection), I do have some (exceedingly trivial - and not necessarily
meaningful) comments on the 'console' module.
1. There's no "exit 0" at the end (after "esac").
For consistency (might apply to a few other modules).
2. For "Native English speakers", the 'Usage: ...' branch is never reached
(for them, the script "dies" at 'if [ -z "${KEYMAP}" ... exit 0'.
Some clever "dummy" construct right at the top might satisfy everyone.
3. For the fortunate multitude who don't speak English natively, I believe
a simple <echo "Usage: ${0} {start}">, instead of
<echo $"Usage:" "${0} {start}">, might work as well.
4. If you ever (future, future) find the above comments worth a second of
your busy time, you might want to insert the start paren on 'cleanfs' module,
Description: ... optionally) /tmp.
Thanks again for your terrific work,
-- Alex
--
http://linuxfromscratch.org/mailman/listinfo/lfs-support
FAQ: http://www.linuxfromscratch.org/lfs/faq.html
Unsubscribe: See the above information page
