On Sun, 04 Sep 2011 12:59:56 -0700
Bryan Kadzban <[email protected]> wrote:

> poptGetNextOption, after it invokes the callback for
> --define-variable=a=b (the operation of which sets the longArg local
> variable), does not reset longArg to NULL.  So on the next time through
> its loop (after invoking the --define-variable callback, before invoking
> the --atleast-pkgconfig-version callback), on line 389 of popt.c, sets
> con->os->nextArg to longArg (the old "a=b" string).  What it should do
> is set nextArg to nextCharArg (the next item on the command line).  This
> happens if longArg is NULL.
> 
> Adding a "longArg = NULL;" as the first line of the "while (!done) {"
> loop makes the tests pass.  I don't *think* it breaks anything else, but
> I don't know for sure.

Well if all the tests pass it's a good sign

> Short patch attached.  It can probably be turned into a sed.

sed -i '/(!done)/a\\tlongArg = NULL;\n' popt/popt.c

Andy
-- 
http://linuxfromscratch.org/mailman/listinfo/lfs-dev
FAQ: http://www.linuxfromscratch.org/faq/
Unsubscribe: See the above information page

Reply via email to