Appearance
==========
In my test case, ufraw crashes with the message "Segmentation fault (core 
dumped)", when I open a Raw image of a camera which is unsupported by lensfun, 
and select in the lens correction tab the model "PanoTools Lens Model".

Commit of introduction
======================
41fa7a (Patch #3532 Fix vignetting in case of non-matching crop factors)

Details
=======
By debugging lfModifier::lfModifier I figured that crop is set to zero by ufraw 
in case that no lensfun profile exists for the specific camera. This causes a 
division by zero when calculating coordinate_correction.
This is a dump of the affected variables at the end of lfModifier::lfModifier:
crop: 0.000000, coordinate_correction: -nan, NormScale: -nan
NormUnScale: -nan, CenterX: -nan, CenterY: -nan
MaxX: -nan, MaxY: -nan

As a result, there is probably an image buffer accessed with out of range 
coordinates.

Suggested fix
=============
Check variables used as divisor for being non-zero before engaging a division. 
Either return an error condition or set the variable to a sane default value.

------------------------------------------------------------------------------
What NetFlow Analyzer can do for you? Monitors network bandwidth and traffic
patterns at an interface-level. Reveals which users, apps, and protocols are 
consuming the most bandwidth. Provides multi-vendor support for NetFlow, 
J-Flow, sFlow and other flows. Make informed decisions using capacity planning
reports.http://sdm.link/zohodev2dev
_______________________________________________
Lensfun-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/lensfun-users

Reply via email to