----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130233/#review103690 -----------------------------------------------------------
kmymoney/converter/mymoneystatementreader.cpp (line 388) <https://git.reviewboard.kde.org/r/130233/#comment68993> I am not sure, if this is a good idea. Reconciliation means, that you have verified the data that your received from the bank and that it matches your records. Doing this automatically in the background somehow defeats the purpose unless checks have been performed that the online balance matches the one on file and that there are no additional transactions that have not been imported from the bank. Maybe, there are more checks required. Ah, and the transactions need to be marked reconciled also. Otherwise, this does not really make sense here. - Thomas Baumgart On Aug. 21, 2017, 10:44 nachm., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130233/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 10:44 nachm.) > > > Review request for KMymoney. > > > Bugs: 323480 > http://bugs.kde.org/show_bug.cgi?id=323480 > > > Repository: kmymoney > > > Description > ------- > > The background is that it was unclear what to use > MyMoneyAccount::setValue("lastStatementDate") or > MyMoneyAccount::setLastReconcilationDate() > > Thomas suggests to use the latter, but there is a location in code using > variant 1 which is fixed also with this commit. > > > Diffs > ----- > > kmymoney/converter/mymoneyqifreader.cpp > 36b865cf142e912cb0db57d5f1a8f5b1f64aa53c > kmymoney/converter/mymoneystatementreader.cpp > e2ea3f820a75238c79dfb6cbef685a2dd60b3cfe > kmymoney/mymoney/mymoneyaccount.cpp > 46be12dfb30daa7a29f88e4de8bebc13d178d526 > > Diff: https://git.reviewboard.kde.org/r/130233/diff/ > > > Testing > ------- > > > Thanks, > > Ralf Habacker > >
