----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130233/#review103689 -----------------------------------------------------------
ping ? - Ralf Habacker On Aug. 21, 2017, 10:44 nachm., Ralf Habacker wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/130233/ > ----------------------------------------------------------- > > (Updated Aug. 21, 2017, 10:44 nachm.) > > > Review request for KMymoney. > > > Bugs: 323480 > http://bugs.kde.org/show_bug.cgi?id=323480 > > > Repository: kmymoney > > > Description > ------- > > The background is that it was unclear what to use > MyMoneyAccount::setValue("lastStatementDate") or > MyMoneyAccount::setLastReconcilationDate() > > Thomas suggests to use the latter, but there is a location in code using > variant 1 which is fixed also with this commit. > > > Diffs > ----- > > kmymoney/converter/mymoneyqifreader.cpp > 36b865cf142e912cb0db57d5f1a8f5b1f64aa53c > kmymoney/converter/mymoneystatementreader.cpp > e2ea3f820a75238c79dfb6cbef685a2dd60b3cfe > kmymoney/mymoney/mymoneyaccount.cpp > 46be12dfb30daa7a29f88e4de8bebc13d178d526 > > Diff: https://git.reviewboard.kde.org/r/130233/diff/ > > > Testing > ------- > > > Thanks, > > Ralf Habacker > >
