----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128511/#review97792 -----------------------------------------------------------
Again, just visual inspection. Looks good to me besides the two little nitpicks. Someone with more knowledge about the functionality should check as well. kmymoney/plugins/csvimport/csvwizard.cpp (line 496) <https://git.reviewboard.kde.org/r/128511/#comment65893> Remove if not needed kmymoney/plugins/csvimport/investprocessing.cpp (line 2368) <https://git.reviewboard.kde.org/r/128511/#comment65892> Why not simply 'm_endColumn++'? Same question applies to the line above. - Thomas Baumgart On Juli 24, 2016, 11:07 vorm., Łukasz Wojniłowicz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/128511/ > ----------------------------------------------------------- > > (Updated Juli 24, 2016, 11:07 vorm.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Purpose of displayLine in tableWidget shouldn't differ whether it's > investment or banking statement, so take of responsibilities of parsing > data into columns and creating memo field from displayLine and put them > into separate functions. > > In csvdialog.cpp and investprocessing.cpp, I introduced createMemoField (it > simplifies memo concatenating and allows to remove some redundant boolean > variables), which in both places looks the same. I think it will be easy to > move it into csvwizard.cpp after trying to move e.g. readFile there, so that > will be next target. > > > Diffs > ----- > > kmymoney/plugins/csvimport/csvdialog.h 69cca6e > kmymoney/plugins/csvimport/csvdialog.cpp fa70b04 > kmymoney/plugins/csvimport/csvwizard.h 28eea62 > kmymoney/plugins/csvimport/csvwizard.cpp 7aee196 > kmymoney/plugins/csvimport/investprocessing.h 38f622c > kmymoney/plugins/csvimport/investprocessing.cpp 328a79b > > Diff: https://git.reviewboard.kde.org/r/128511/diff/ > > > Testing > ------- > > Banking and investment statement CSV imports; with and without setup. > > > Thanks, > > Łukasz Wojniłowicz > >
