----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128511/ -----------------------------------------------------------
Review request for KMymoney. Repository: kmymoney Description ------- Purpose of displayLine in tableWidget shouldn't differ whether it's investment or banking statement, so take of responsibilities of parsing data into columns and creating memo field from displayLine and put them into separate functions. In csvdialog.cpp and investprocessing.cpp, I introduced createMemoField (it simplifies memo concatenating and allows to remove some redundant boolean variables), which in both places looks the same. I think it will be easy to move it into csvwizard.cpp after trying to move e.g. readFile there, so that will be next target. Diffs ----- kmymoney/plugins/csvimport/csvdialog.h 69cca6e kmymoney/plugins/csvimport/csvdialog.cpp fa70b04 kmymoney/plugins/csvimport/csvwizard.h 28eea62 kmymoney/plugins/csvimport/csvwizard.cpp 7aee196 kmymoney/plugins/csvimport/investprocessing.h 38f622c kmymoney/plugins/csvimport/investprocessing.cpp 328a79b Diff: https://git.reviewboard.kde.org/r/128511/diff/ Testing ------- Banking and investment statement CSV imports; with and without setup. Thanks, Łukasz Wojniłowicz
