-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124957/
-----------------------------------------------------------
(Updated Aug. 31, 2015, 10:05 p.m.)
Review request for KMymoney.
Changes
-------
The previous patch would change a loss into a profit when the commission on a
sale was greater than the sale price. (KMM version 4.72 does the same thing.)
I don't see a way to import that class of transaction without changing the
statement reader, because the statement reader sets the sign on the amount
based on whether the transaction is a buy or sell, expecting a buy to cost
money and a sale to bring in money. But in this particular case, a sale costs
money.
With this patch, the imported sale that costs money gets a warning triangle in
the ledger. Just editing the transaction on the ledger page, and then
selecting "Enter" without changing anything corrects the transaction and the
warning triangle goes away. Since this situtaion should be uncommon, I think
that is acceptable, and doesn't require changing the statement reader.
Bugs: 351874
http://bugs.kde.org/show_bug.cgi?id=351874
Repository: kmymoney
Description
-------
Changes made so that the commission for an investment buy or sell is only added
to the transaction total one time instead of three times.
Diffs (updated)
-----
kmymoney/converter/mymoneyqifreader.cpp d07b9b9
Diff: https://git.reviewboard.kde.org/r/124957/diff/
Testing
-------
Tested using exports of investment accounts from Quicken 2013.
Thanks,
Jeff Lundblad
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
