----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124957/#review84589 -----------------------------------------------------------
Changes to the MyMoneyStatementReader object also influence imports using other mechanisms than QIF like OFX and HBCI. Did you check that those changes don't affect them? kmymoney/converter/mymoneyqifreader.cpp (line 1568) <https://git.reviewboard.kde.org/r/124957/#comment58545> Isn't -(amount - tr.m_fees) correct? See line #1531 for similar circumstances - Thomas Baumgart On Aug. 27, 2015, 11:38 nachm., Jeff Lundblad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/124957/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2015, 11:38 nachm.) > > > Review request for KMymoney. > > > Bugs: 351874 > http://bugs.kde.org/show_bug.cgi?id=351874 > > > Repository: kmymoney > > > Description > ------- > > Changes made so that the commission for an investment buy or sell is only > added to the transaction total one time instead of three times. > > > Diffs > ----- > > kmymoney/converter/mymoneyqifreader.cpp d07b9b9 > kmymoney/converter/mymoneystatementreader.cpp 1634bbb > > Diff: https://git.reviewboard.kde.org/r/124957/diff/ > > > Testing > ------- > > Tested using exports of investment accounts from Quicken 2013. > > > Thanks, > > Jeff Lundblad > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel