> On März 25, 2015, 10:08 nachm., Jack Ostroff wrote: > > You say "Don't allow the user to add a transaction after the opening date > > of all accounts involved in the transaction." Do you mean "Don't allow the > > user to add a transaction BEFORE the opening date of ANY of the accounts > > involved in the transaction" ? The transaction date should be after all > > the opening dates, unless I'm really confused (which is certainly possible.) > > Cristian Oneț wrote: > Yes, I should have said before, I'll fix it.
No, you're not confused. That is what Cristian implemented. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122746/#review78045 ----------------------------------------------------------- On März 27, 2015, 7:29 vorm., Cristian Oneț wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122746/ > ----------------------------------------------------------- > > (Updated März 27, 2015, 7:29 vorm.) > > > Review request for KMymoney. > > > Bugs: 313793 > http://bugs.kde.org/show_bug.cgi?id=313793 > > > Repository: kmymoney > > > Description > ------- > > If the transaction is moved to another post date the price information > is moved along with it for investments transactions. This fixes the > reported issue, saving the file once will fix all price issues. > > Also add the possibility to save the consistency check log to a file > or copy it into the clipboard. > > Make sure that the user enters a valid transaction date by checking > that the transaction date is after the opening date of each and every > account involved in the transaction. Until now we only checked that > the transaction date is after the opening date of the account in which > is being entered. > > BUG: 313793 > REVIEW: 122746 > > > Diffs > ----- > > kmymoney/dialogs/transactioneditor.cpp > a215e3f8a1eaf2f7ccf1d73f29190f2ad86ff282 > kmymoney/kmymoney.h 92ab4b28d52c237222a2fb1106398ce0208215aa > kmymoney/kmymoney.cpp c132983b63536e094375532082ea87c54461235c > kmymoney/mymoney/mymoneyfile.cpp 8c1be4301a89b65f428edf2b8f0ab8b6e3dac51e > > Diff: https://git.reviewboard.kde.org/r/122746/diff/ > > > Testing > ------- > > Opened the file attached to the report and observe that the consistency check > fixes all of the issues. > > > Thanks, > > Cristian Oneț > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
