> On März 5, 2015, 10:20 nachm., Thomas Baumgart wrote: > > kmymoney/mymoney/mymoneyfile.cpp, line 2132 > > <https://git.reviewboard.kde.org/r/122746/diff/1/?file=352318#file352318line2132> > > > > Would it probably make sense to adjust the account's opening date > > instead? > > Jack Ostroff wrote: > Unfortunately, I think it depends on the user. If the account opening > date was just set without a serious reason (such as last year, if it is > actually an older account but it will only be tgraqcked from this year) then > moving the opening date is OK. However, if someone has actually set the > opening date to when the account was opened, then just changing it is bad - > as there is probably some problem with trying to put an older transaction in > that account. While I hate to propose another popup warning/question to the > user, what about asking: "This transaction is on a date prior to the opening > date of the account." and offer to "Move account opening date." or "Cancel" ? > > Cristian Oneț wrote: > I haven't thought about that but Jack also has a point. In the case of > the file attached to the bug report the transaction date and the opening date > differed by a few weeks. It sounds as changing the account opening date would > be a better solution but it would be harder to implement since this is the > transactions processing step in the consistency check. I was thinking that > the transaction date, altough I admit that it's more important, should be > adjusted because when a transaction is entered in the ledger that date is > adjusted to fit the account's opening date and not the otherway around. The > application does not say: "You are trying to enter a transaction prior to the > account's opening date, would you like to adjust the account's opening date?" > > Cristian Oneț wrote: > I'm thinking that this feature (transactions fixup) would only be > complete if the consistency chek report could be easily saved to a file and > KMyMoney would allow searching transactions by the transaction id. This way > the user could review the consistency check fixes. I'm really against > actively involving the user with decisions during the consistency check which > could become a mess for a lot of fixups.
I completely agree with Cristian about the user interaction during the consistency check run. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122746/#review77066 ----------------------------------------------------------- On Feb. 27, 2015, 8:56 nachm., Cristian Oneț wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/122746/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2015, 8:56 nachm.) > > > Review request for KMymoney. > > > Bugs: 313793 > http://bugs.kde.org/show_bug.cgi?id=313793 > > > Repository: kmymoney > > > Description > ------- > > If the transaction is moved to another post date the price information > is moved along with it for investments transactions. This fixes the > reported issue, saving the file once will fix all price issues. > > BUG:313793 > > Also fix some old code that added prices when entering transaction, there is > no such action as "Sell". > > BTW: currently it's possible to enter a transaction prior to the opening date > of an account by making a transfer to that account from another account which > has an older opening date, should we fix that? > > > Diffs > ----- > > kmymoney/dialogs/transactioneditor.cpp > 1aadc6fc96b7d21c7da198e92900023100fda9ad > kmymoney/mymoney/mymoneyfile.cpp 8c1be4301a89b65f428edf2b8f0ab8b6e3dac51e > > Diff: https://git.reviewboard.kde.org/r/122746/diff/ > > > Testing > ------- > > Opened the file attached to the report and observe that the consistency check > fixes all of the issues. > > > Thanks, > > Cristian Oneț > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
