----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120339/#review68647 -----------------------------------------------------------
kmymoney/plugins/weboob/weboob.cpp <https://git.reviewboard.kde.org/r/120339/#comment47850> It would be nice if scipt errors like "Woboob not installed" could be handled here and somehow would end up in the UI. I've just tested this without Weboob installed and Kross::ErrorInterface returns an interpretor error. This extreme case could be handled by cmake (detecting Woboob availability) but other python errors should be handled. Anyway this is a "would be nice to have feature" so I won't open an issue for it. - Cristian Oneț On Oct. 7, 2014, 4:06 p.m., Florent Fourcot wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120339/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2014, 4:06 p.m.) > > > Review request for KMymoney. > > > Repository: kmymoney > > > Description > ------- > > Weboob (http://weboob.org) is a library and a collection of applications to > extract data from the Web. One of the features is to simplify online banking, > on many french banks and several outside of France. About 33 modules are > currently available. > > This module provides a easy way to import the transactions extracted by > Weboob in Kmymoney, providing an online banking like the aqbanking module. > > > Diffs > ----- > > kmymoney/plugins/weboob/weboob.cpp PRE-CREATION > kmymoney/plugins/weboob/weboob.py PRE-CREATION > CMakeLists.txt dd3191d > kmymoney/plugins/CMakeLists.txt eb3a62f > kmymoney/plugins/weboob/CMakeLists.txt PRE-CREATION > kmymoney/plugins/weboob/dialogs/CMakeLists.txt PRE-CREATION > kmymoney/plugins/weboob/dialogs/mapaccount.h PRE-CREATION > kmymoney/plugins/weboob/dialogs/mapaccount.cpp PRE-CREATION > kmymoney/plugins/weboob/dialogs/mapaccount.ui PRE-CREATION > kmymoney/plugins/weboob/dialogs/webaccount.h PRE-CREATION > kmymoney/plugins/weboob/dialogs/webaccount.cpp PRE-CREATION > kmymoney/plugins/weboob/dialogs/webaccount.ui PRE-CREATION > kmymoney/plugins/weboob/kmm_weboob.desktop PRE-CREATION > kmymoney/plugins/weboob/kmm_weboob.rc PRE-CREATION > kmymoney/plugins/weboob/plugin.h PRE-CREATION > kmymoney/plugins/weboob/plugin.cpp PRE-CREATION > kmymoney/plugins/weboob/weboob.h PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120339/diff/ > > > Testing > ------- > > The module needs krosspython to work. It works on both debian stable/debian > sid. > > All comments of Christian David have been fixed in the V2. > > > Thanks, > > Florent Fourcot > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
