> On July 16, 2014, 12:52 a.m., Michael Pyne wrote:
> >
> 
> Marko Käning wrote:
>     So, basically, you're saying that this whole RR can be discarded, because 
> everything is already defined in file "dependency-data", right!?
>     Good news. :)

Well there's two different things going on.

logical-module-structure (the stuff that's already filled in) helps relate 
which git branch for a module is used to build KF5-based versions, which git 
branch for the same module is used to build KDE4-based versions, etc. But it 
doesn't define dependencies between KDE git modules.

dependency-data-$FOO does that (for FOO = kf5-qt5, latest-qt4, etc.), and 
that's what would still need to be modified for kmymoney.

In the current scheme the dependency-data-* files let the CI know what order to 
build the KDE git modules in, while the logical-module-structure lets the CI 
know what specific branch of each KDE git module to build when the build is 
actually performed. You really should have both defined for KF5 modules to be 
supported properly by the CI infrastructure and kdesrc-build.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119305/#review62454
-----------------------------------------------------------


On July 16, 2014, 12:32 a.m., Marko Käning wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119305/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 12:32 a.m.)
> 
> 
> Review request for KMymoney, Ben Cooksley and Michael Pyne.
> 
> 
> Repository: kde-build-metadata
> 
> 
> Description
> -------
> 
> Herewith I intended to bring kmymoney to the OSX/CI system, but it is still 
> also missing on the linux system for KF5...
> 
> 
> Diffs
> -----
> 
>   dependency-data-kf5-qt5 6819771be9eeddd37586570dd63b5fe9115c554e 
> 
> Diff: https://git.reviewboard.kde.org/r/119305/diff/
> 
> 
> Testing
> -------
> 
> It doesn't build yet, since I don't know how to handle the optional deps to 
> frameworks Holidays, Gpgmepp and QGpgme.
> 
> Alkimia is still not building on OSX, though. (Its logical dependency 
> structure already exists.) 
> 
> I'll post the problem on kmymoney-devel.
> 
> 
> Thanks,
> 
> Marko Käning
> 
>

_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel

Reply via email to