> On Jan. 19, 2013, 6:39 a.m., Thomas Baumgart wrote: > > I have a added a few naming issues. No big deal. Otherwise, it looks good > > to me.
I'll take care of these naming issues before I commit this patch. Anyway, on my TODO is still the splitting up of the corresponding test into separate test functions, as suggested by Lukazs. > On Jan. 19, 2013, 6:39 a.m., Thomas Baumgart wrote: > > kmymoney/mymoney/mymoneyfile.cpp, line 2933 > > <http://git.reviewboard.kde.org/r/108150/diff/8/?file=107793#file107793line2933> > > > > I am not sure if any optimizer reduces that to > > > > return transactionList(filter).count(); > > > > which is all we need. This is what I get if I try it without a QList inserted: /Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfile.cpp: In member function ‘int MyMoneyFile::countTransactionsWithSpecificReconcileState(const QString&, MyMoneyTransactionFilter::stateOptionE) const’: /Users/marko/WC/GIT/kmymoney.homeview-additional_columns/kmymoney/mymoney/mymoneyfile.cpp:2933: error: ‘((const MyMoneyFile*)this)->MyMoneyFile::transactionList’ does not have class type make[2]: *** [kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/mymoneyfile.cpp.o] Error 1 make[1]: *** [kmymoney/mymoney/CMakeFiles/kmm_mymoney.dir/all] Error 2 - Marko ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108150/#review25776 ----------------------------------------------------------- On Jan. 18, 2013, 10:11 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108150/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2013, 10:11 p.m.) > > > Review request for KMymoney and Łukasz Maszczyński. > > > Description > ------- > > This patch introduces 3 new columns in the accounts tables on KMM's homepage > (similar to [1]) which will list the number of > > a) not marked ('!M'), > > b) "only" cleared ('C'), > > c) as well as all not reconciled ('!R') > > transactions for each specific account. > > > Every one of these columns can be individually switched on. > > > This information will give the user the chance to immediately spot accounts > which might need to be looked after. > > > --- > [1] "homepage: extend accounts table with additional columns to reflect > online-status" https://git.reviewboard.kde.org/r/107364/ > > > Diffs > ----- > > kmymoney/dialogs/settings/ksettingshomedecl.ui > 4cb36cced4801f5d6ecf35ef84f375a629cd8792 > kmymoney/kmymoney.kcfg a60ccad153385c961fa15c5b0964588c14e7ad89 > kmymoney/mymoney/mymoneyfile.h 0f114457877e6cebc44ce991741984643e409136 > kmymoney/mymoney/mymoneyfile.cpp eb99876a924d13287f3d80786d2da6b05dfd3417 > kmymoney/mymoney/mymoneyfiletest.h 5e397981c40eb006449fb73fd58a006b8fc16d82 > kmymoney/mymoney/mymoneyfiletest.cpp > c831ad3586756b91469567dd934cbd0165df570d > kmymoney/views/khomeview.cpp 7da6980b866ff2523ddfb07e0826d3394d1b7157 > > Diff: http://git.reviewboard.kde.org/r/108150/diff/ > > > Testing > ------- > > Builds, tests and runs fine. > > TODO: > - implement sub-tests as separate test-functions > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
