----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108150/#review25776 -----------------------------------------------------------
Ship it! I have a added a few naming issues. No big deal. Otherwise, it looks good to me. kmymoney/dialogs/settings/ksettingshomedecl.ui <http://git.reviewboard.kde.org/r/108150/#comment19692> I would suggest to name this setting kcfg_ShowCountOfUnmarkedTransactions kmymoney/dialogs/settings/ksettingshomedecl.ui <http://git.reviewboard.kde.org/r/108150/#comment19693> I would suggest to name this setting kcfg_ShowCountOfClearedTransactions kmymoney/dialogs/settings/ksettingshomedecl.ui <http://git.reviewboard.kde.org/r/108150/#comment19694> I would suggest to name this setting kcfg_ShowCountOfNotReconciledTransactions kmymoney/mymoney/mymoneyfile.h <http://git.reviewboard.kde.org/r/108150/#comment19695> Isn't it called reconciliation state? kmymoney/mymoney/mymoneyfile.cpp <http://git.reviewboard.kde.org/r/108150/#comment19696> I am not sure if any optimizer reduces that to return transactionList(filter).count(); which is all we need. - Thomas Baumgart On Jan. 18, 2013, 11:11 p.m., Marko Käning wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108150/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2013, 11:11 p.m.) > > > Review request for KMymoney and Łukasz Maszczyński. > > > Description > ------- > > This patch introduces 3 new columns in the accounts tables on KMM's homepage > (similar to [1]) which will list the number of > > a) not marked ('!M'), > > b) "only" cleared ('C'), > > c) as well as all not reconciled ('!R') > > transactions for each specific account. > > > Every one of these columns can be individually switched on. > > > This information will give the user the chance to immediately spot accounts > which might need to be looked after. > > > --- > [1] "homepage: extend accounts table with additional columns to reflect > online-status" https://git.reviewboard.kde.org/r/107364/ > > > Diffs > ----- > > kmymoney/dialogs/settings/ksettingshomedecl.ui > 4cb36cced4801f5d6ecf35ef84f375a629cd8792 > kmymoney/kmymoney.kcfg a60ccad153385c961fa15c5b0964588c14e7ad89 > kmymoney/mymoney/mymoneyfile.h 0f114457877e6cebc44ce991741984643e409136 > kmymoney/mymoney/mymoneyfile.cpp eb99876a924d13287f3d80786d2da6b05dfd3417 > kmymoney/mymoney/mymoneyfiletest.h 5e397981c40eb006449fb73fd58a006b8fc16d82 > kmymoney/mymoney/mymoneyfiletest.cpp > c831ad3586756b91469567dd934cbd0165df570d > kmymoney/views/khomeview.cpp 7da6980b866ff2523ddfb07e0826d3394d1b7157 > > Diff: http://git.reviewboard.kde.org/r/108150/diff/ > > > Testing > ------- > > Builds, tests and runs fine. > > TODO: > - implement sub-tests as separate test-functions > > > Thanks, > > Marko Käning > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
