-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107797/
-----------------------------------------------------------
(Updated Dec. 23, 2012, 12:11 p.m.)
Review request for KMymoney.
Changes
-------
I've now extracted the common code from the separate sections and moved that
processing to be immediately before those sections.
The new patch replaces the original one.
I've also made a minor change in
MyMoneyQifReader::processInvestmentTransactionEntry(). Originally, in -
"if ((xAction == true)
|| (d->isTransfer(tmp, m_qifProfile.accountDelimiter().left(1),
m_qifProfile.accountDelimiter().mid(1, 1)) == true))"
this statement had "&&" rather than "||".
This was changed as it was felt that either condition should result in a
transfer, not just the combination. Otherwise, if only one condition was met,
what should happen?
Tested with numerous QIF files.
Now, a brokerage account is created only if no transfer account name is
provided. That is, there is an 'X' suffix and either no 'L' record or an empty
one, ('L[]') or ('L').
Description
-------
When importing a QIF file which contains investment accounts, a Brokerage
account is created for each account, even if the transactions include a name
for the investment account to be used. This is because the Brokerage account is
created when the investment account line is encountered, and before the start
of the transactions processing. If several accounts are being imported, this
creates a lot of clutter.
The change delays the decision on Brokerage account creation until transaction
processing occurs.
This addresses bug 213250.
http://bugs.kde.org/show_bug.cgi?id=213250
Diffs (updated)
-----
kmymoney/converter/mymoneyqifreader.h c103dc0
kmymoney/converter/mymoneyqifreader.cpp d535091
Diff: http://git.reviewboard.kde.org/r/107797/diff/
Testing
-------
Tested successfully with a number of different QIF files.
Thanks,
Allan Anderson
_______________________________________________
KMyMoney-devel mailing list
KMyMoney-devel@kde.org
https://mail.kde.org/mailman/listinfo/kmymoney-devel
