----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107797/#review25422 -----------------------------------------------------------
Ship it! Looks good to me and certainly makes sense. kmymoney/converter/mymoneyqifreader.cpp <http://git.reviewboard.kde.org/r/107797/#comment19441> Please check indentation (or run astyle) before you commit - Thomas Baumgart On Dec. 23, 2012, 12:11 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/107797/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2012, 12:11 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > When importing a QIF file which contains investment accounts, a Brokerage > account is created for each account, even if the transactions include a name > for the investment account to be used. This is because the Brokerage account > is created when the investment account line is encountered, and before the > start of the transactions processing. If several accounts are being > imported, this creates a lot of clutter. > The change delays the decision on Brokerage account creation until > transaction processing occurs. > > > This addresses bug 213250. > http://bugs.kde.org/show_bug.cgi?id=213250 > > > Diffs > ----- > > kmymoney/converter/mymoneyqifreader.h c103dc0 > kmymoney/converter/mymoneyqifreader.cpp d535091 > > Diff: http://git.reviewboard.kde.org/r/107797/diff/ > > > Testing > ------- > > Tested successfully with a number of different QIF files. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
